Increase BLE transfer timeout from 45s to 120s#6
Open
deepseven wants to merge 1 commit intoskorokithakis:masterfrom
Open
Increase BLE transfer timeout from 45s to 120s#6deepseven wants to merge 1 commit intoskorokithakis:masterfrom
deepseven wants to merge 1 commit intoskorokithakis:masterfrom
Conversation
The 45-second timeout is too aggressive for larger recordings transferred over BLE. A single 3-minute recording at ~32 kbit/s IMA-ADPCM produces roughly 720 KB, which at typical BLE throughput (10-15 KB/s with notification overhead) takes 48-72 seconds to transfer. Increasing to 120 seconds gives comfortable headroom while still bounding the worst case. The real protection against stuck transfers should come from stall detection (checking whether data is still flowing) rather than an aggressive overall timeout.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 45-second timeout is too aggressive for larger recordings transferred over BLE. A single 3-minute recording at ~32 kbit/s IMA-ADPCM produces roughly 720 KB, which at typical BLE throughput (10-15 KB/s with notification overhead) takes 48-72 seconds to transfer.
Increasing to 120 seconds gives comfortable headroom while still bounding the worst case. The real protection against stuck transfers should come from stall detection (checking whether data is still flowing) rather than an aggressive overall timeout.